[LBBS-50] mod_chanserv: NULL dereference when joining IRC channel

← All Issues || New Issue →

Sort Normal || Priority

Details

On a system without MySQL integration with LBBS (e.g. just using static auth), the ChanServ module causes a crash.

Workarounds are to not load mod_chanserv or to ensure mod_mysql is configured and running.

Thread 1 (Thread 0x7f5b99ffb6c0 (LWP 71383)):
#0  0x00007f5baaebae0b in mysql_stmt_init () at /lib/x86_64-linux-gnu/libmariadb.so.3
#1  0x00007f5ba80a3a26 in channel_get_entrymsg (stmt=0x0, len=256, buf=0x7f5b99ffa480 "", channel=0x7f5b8c001e88 "#channel") at mod_chanserv.c:326
        res = -1
        connlocal = 1
        mysql = 0x0
        entrymsg = '\000' <repeats 255 times>
        __func__ = "event_cb"
#2  event_cb (cmd=<optimized out>, channel=0x7f5b8c001e88 "#channel", username=<optimized out>, data=<optimized out>) at mod_chanserv.c:1057
        entrymsg = '\000' <repeats 255 times>
        __func__ = "event_cb"
#3  0x00007f5bab9cebb1 in join_channel (user=user@entry=0x7f5b8c000e80, name=<optimized out>) at net_irc.c:2862

This also looks suspicious, since we shouldn't be attempting to connect to MySQL as part of the IRC authentication process:

[2024-07-08 15:12:41.346]   ERROR[71443]: mod_mysql.c:84 sql_connect_db: mysql error 2002 [HY000]: Can't connect to local server through socket '/run/mysqld/mysqld.sock' (2)
[2024-07-08 15:12:41.346]    AUTH[71443]: auth.c:624 bbs_user_authenticate: Login attempt rejected for user REDACTED (wrong password)

Comments

You must be logged in to leave a comment.