[ASTERISK-19] chan_dahdi: Remove sig_analog paths

← All Issues || New Issue →

Sort Normal || Priority

Details

There is a WIP patch included in PhreakScript to remove paths in chan_dahdi.c that were mostly moved to sig_analog.c

This is a much-needed improvement as it will trim thousands of lines of dead code from chan_dahdi.c. However, it is imperative not to remove any code that actually is still used on certain (if infrequent) paths. The current WIP patch adds assertions to catch these.

I recently observed this assertion when testing PRI, so this needs to be addressed and the patch updated:

[Jun 23 08:07:11]   == Primary D-Channel on span 3 down
[Jun 23 08:07:11] WARNING[5688]: sig_pri.c:1185 pri_find_dchan: Span 3: D-channel is down!
[Jun 23 08:07:12] NOTICE[5688]: chan_dahdi.c:3023 my_handle_dchan_exception: Got DAHDI event: Alarm (4) on D-channel of span 3
[Jun 23 08:07:12] WARNING[5689]: chan_dahdi.c:7700 handle_alarms: Detected alarm on channel 49: Red Alarm
[Jun 23 08:07:12] WARNING[5689]: chan_dahdi.c:11759 handle_init_event: Unexpectedly using analog handler at line 11759 (radio 0, oprmode 0)

[2024-08-04 16:54:30.557]   == Starting D-Channel on span 3
[2024-08-04 16:54:31.216] WARNING[2523]: chan_dahdi.c:7780 handle_alarms: Detected alarm on channel 25: Red Alarm
[2024-08-04 16:54:31.287] NOTICE[2522]: chan_dahdi.c:3088 my_handle_dchan_exception: Got DAHDI event: Alarm (4) on D-channel of span 3
[2024-08-04 16:54:31.287] WARNING[2522]: sig_pri.c:1185 pri_find_dchan: Span 3: D-channel is down!
[2024-08-04 16:54:31.287] WARNING[2523]: chan_dahdi.c:7780 handle_alarms: Detected alarm on channel 49: Red Alarm
[2024-08-04 16:54:31.287] WARNING[2523]: chan_dahdi.c:11859 handle_init_event: Unexpectedly using analog handler at line 11859 (radio 0, oprmode 0)
[2024-08-04 16:54:31.287] ERROR[2523]: chan_dahdi.c:11859 handle_init_event: FRACK!, Failed assertion 0 (0)

Comments

You must be logged in to leave a comment.