[DAHLIN-18] Avoid flushing system-wide workqueues (calls to __warn_flushing_systemwide_wq)

← All Issues || New Issue →

Sort Normal || Priority

Details

(Non-fatal) compiler warnings when compiling DAHDI Linux on Rocky Linux 9.5:

 CC [M]  /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.o
In file included from ./include/linux/srcu.h:21,
                 from ./include/linux/notifier.h:16,
                 from ./arch/x86/include/asm/uprobes.h:13,
                 from ./include/linux/uprobes.h:49,
                 from ./include/linux/mm_types.h:16,
                 from ./include/linux/buildid.h:5,
                 from ./include/linux/module.h:14,
                 from /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c:43:
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c: In function ‘wctdm_remove_one’:
./include/linux/workqueue.h:737:9: warning: call to ‘__warn_flushing_systemwide_wq’ declared with attribute warning: Please avoid flushing system-wide workqueues. [-Wattribute-warning]
  737 |         __warn_flushing_systemwide_wq();                                \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c:6026:9: note: in expansion of macro ‘flush_scheduled_work’
 6026 |         flush_scheduled_work();
      |         ^~~~~~~~~~~~~~~~~~~~
./include/linux/workqueue.h:737:9: warning: call to ‘__warn_flushing_systemwide_wq’ declared with attribute warning: Please avoid flushing system-wide workqueues. [-Wattribute-warning]
  737 |         __warn_flushing_systemwide_wq();                                \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c:6026:9: note: in expansion of macro ‘flush_scheduled_work’
 6026 |         flush_scheduled_work();
      |         ^~~~~~~~~~~~~~~~~~~~
./include/linux/workqueue.h:737:9: warning: call to ‘__warn_flushing_systemwide_wq’ declared with attribute warning: Please avoid flushing system-wide workqueues. [-Wattribute-warning]
  737 |         __warn_flushing_systemwide_wq();                                \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/base.c:6026:9: note: in expansion of macro ‘flush_scheduled_work’
 6026 |         flush_scheduled_work();
      |         ^~~~~~~~~~~~~~~~~~~~
  CC [M]  /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/xhfc.o
  LD [M]  /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm24xxp/wctdm24xxp.o

 CC [M]  /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wcaxx-base.o
In file included from ./include/linux/srcu.h:21,
                 from ./include/linux/notifier.h:16,
                 from ./arch/x86/include/asm/uprobes.h:13,
                 from ./include/linux/uprobes.h:49,
                 from ./include/linux/mm_types.h:16,
                 from ./include/linux/buildid.h:5,
                 from ./include/linux/module.h:14,
                 from /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wcaxx-base.c:27:
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wcaxx-base.c: In function ‘wcaxx_remove_one’:
./include/linux/workqueue.h:737:9: warning: call to ‘__warn_flushing_systemwide_wq’ declared with attribute warning: Please avoid flushing system-wide workqueues. [-Wattribute-warning]
  737 |         __warn_flushing_systemwide_wq();                                \
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/dahdi-linux-3.4.0/drivers/dahdi/wcaxx-base.c:4409:9: note: in expansion of macro ‘flush_scheduled_work’
 4409 |         flush_scheduled_work();
      |         ^~~~~~~~~~~~~~~~~~~~
  LD [M]  /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wcaxx.o
  CC [M]  /usr/src/dahdi-linux-3.4.0/drivers/dahdi/wctdm.o

Comments

You must be logged in to leave a comment.