[LBBS-96] pty: CR NUL is sometimes split up, leaking to flaky test

← All Issues || New Issue →

Sort Normal || Priority

Details

test_terminals occasionally fails, as shown below. This seems to be because a CR NUL sequence is sent in the tests, and then somehow the first character received is NUL, leading to the password being "wrong".

[2025-02-25 00:04:15.791]   DEBUG[36120]: pty.c:659 pty_master: Got CR NUL, translating to CR for slave
[2025-02-25 00:04:15.791]   DEBUG[36120]: pty.c:763 pty_master: Received ^M, forwarding it
[2025-02-25 00:04:15.791]   DEBUG[36119]: socket.c:1698 bbs_node_poll: Node 2: poll returned 1
[2025-02-25 00:04:15.791]   DEBUG[36119]: socket.c:1698 bbs_node_poll: Node 2: poll returned 1
[2025-02-25 00:04:15.791]   DEBUG[36119]: socket.c:1828 bbs_node_read: Node 2: read 1 byte (10)
[2025-02-25 00:04:15.791]   DEBUG[36119]: socket.c:2282 bbs_node_flush_input: Flushed 1 byte
[2025-02-25 00:04:15.791]   DEBUG[36119]: socket.c:1698 bbs_node_poll: Node 2: poll returned 0
[2025-02-25 00:04:15.791]   DEBUG[36119]: event.c:141 bbs_event_broadcast: Event NODE_INTERACTIVE_START dispatched and not consumed
[2025-02-25 00:04:15.791]   DEBUG[36119]: term.c:116 bbs_node_set_input: Node 2 (fd 13): input now buffered, echo enabled
[2025-02-25 00:04:15.791]   DEBUG[36119]: socket.c:1698 bbs_node_poll: Node 2: poll returned 1
[2025-02-25 00:04:15.791]   DEBUG[36119]: socket.c:1830 bbs_node_read: Node 2: read 9 bytes
[2025-02-25 00:04:15.796]   DEBUG[36119]: socket.c:1698 bbs_node_poll: Node 2: poll returned 0
[2025-02-25 00:04:15.796]   DEBUG[36119]: socket.c:2142 bbs_node_readline: Node 2: read(9) termtest
[2025-02-25 00:04:15.872]   DEBUG[36120]: pty.c:659 pty_master: Got CR NUL, translating to CR for slave
[2025-02-25 00:04:15.873]   DEBUG[36120]: pty.c:763 pty_master: Received ^M, forwarding it
[2025-02-25 00:04:15.873]   DEBUG[36119]: socket.c:1698 bbs_node_poll: Node 2: poll returned 1
[2025-02-25 00:04:15.873]   DEBUG[36119]: socket.c:1830 bbs_node_read: Node 2: read 10 bytes
[2025-02-25 00:04:15.873]   DEBUG[36119]: socket.c:2139 bbs_node_readline: First character received was NUL?
[2025-02-25 00:04:15.873]   DEBUG[36119]: socket.c:2142 bbs_node_readline: Node 2: read(10) 
[2025-02-25 00:04:15.873]   DEBUG[36119]: event.c:141 bbs_event_broadcast: Event NODE_LOGIN_FAILED dispatched and not consumed
[2025-02-25 00:04:15.873]   DEBUG[36119]: term.c:109 bbs_node_set_input: Buffering/echo settings (1/1) have not changed for node 2
[2025-02-25 00:04:19.381]   DEBUG[36115]: socket.c:1698 bbs_node_poll: Node 1: poll returned 0
[2025-02-25 00:04:20.914] WARNING: test.c:363 test_client_expect_eventually_buf: Failed to receive expected output at line 201: Hit a key
[2025-02-25 00:04:20.915]   DEBUG: test.c:877 run_test: Test '/home/runner/work/lbbs/lbbs/tests/test_terminals.so' returned -1

Comments

You must be logged in to leave a comment.