[PHREAKSCRIPT-63] chan_dahdi: Unused variable x

← All Issues || New Issue →

Sort Normal || Priority

Details

   [CCi] chan_dahdi.i -> chan_dahdi.o
chan_dahdi.c: In function ‘dahdi_handle_event’:
chan_dahdi.c:7840:11: error: unused variable ‘x’ [-Werror=unused-variable]
 7840 |  int res, x;
      |       

I think when HAVE_PRI is not defined or some of the optional DAHDI dependencies are not present, building of chan_dahdi fails with the massive DAHDI refactor patch: https://code.phreaknet.org/asterisk/dahdicleanup.diff

Tentative patch that possibly solves this issue:

static struct ast_frame *dahdi_handle_event(struct ast_channel *ast)
{
-        int res, x;
+#if !defined(SIG_ANALOG_HANDLED) || defined(HAVE_PRI)
+        int x;
+#endif

To validate, additional builds should be added that also build chan_dahdi without all of the optional dependencies, e.g. without libpri, etc.

Comments

You must be logged in to leave a comment.